Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement mongo insertMany #505

Merged
merged 22 commits into from
Jan 15, 2024
Merged

feat: Implement mongo insertMany #505

merged 22 commits into from
Jan 15, 2024

Conversation

jonas-martinez
Copy link
Collaborator

@jonas-martinez jonas-martinez commented Dec 4, 2023

About this PR

Closes #504

Technical highlight/advice

How to test my changes

Checklist

  • I didn't over-scope my PR
  • My PR title matches the commit convention
  • I did not include breaking changes
  • I made my own code-review before requesting one

I included unit tests that cover my changes

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

I added/updated the documentation about my changes

  • 📜 README.md
  • 📕 docs/*.md
  • 📓 docs.lenra.io
  • 🙅 no documentation needed

@jonas-martinez jonas-martinez added the enhancement New feature or request label Dec 4, 2023
@jonas-martinez jonas-martinez self-assigned this Dec 4, 2023
@jonas-martinez jonas-martinez changed the title feat: Implement mongo insertMany [WIP] feat: Implement mongo insertMany Dec 4, 2023
@jonas-martinez jonas-martinez changed the title [WIP] feat: Implement mongo insertMany feat: Implement mongo insertMany Dec 6, 2023
@jonas-martinez
Copy link
Collaborator Author

I can't find a way to make dialyzer work for this feature, it tells me that mongo.insert_many always returns an error tuple.

@jonas-martinez jonas-martinez removed the request for review from taorepoara December 6, 2023 15:01
.formatter.exs Outdated Show resolved Hide resolved
libs/application_runner/lib/mongo_storage.ex Outdated Show resolved Hide resolved
Copy link
Member

@taorepoara taorepoara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK but need API update

@taorepoara taorepoara merged commit 711135d into main Jan 15, 2024
4 checks passed
@taorepoara taorepoara deleted the insert-many branch January 15, 2024 09:47
@taorepoara
Copy link
Member

🎉 This PR is included in version 1.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Implement insertMany in mongo doc creation.
2 participants